search

courselab / snaskii22

Programming exercise based on snaskii (class of 2022)
GNU General Public License v3.0
8 stars 11 forks source link

Add ultils.c to Makefile.am #66

Closed Grillo-0 closed 1 year ago

Grillo-0 commented 1 year ago

On the conversion made on #63 the utils.c was left out of the snaskii_bin_SOURCES. This is not correct as all the translation units need to be on this variable

pedrolmcastro commented 1 year ago

Actually, I think utils.c should not exist any more, if you look at utils.h there is only a macro, no function header or extern variable to live in a translation unit of its own, the correct thing would be to rm the file since there is no need for it anymore

Grillo-0 commented 1 year ago

Actually, I think utils.c should not exist any more, if you look at utils.h there is only a macro, no function header or extern variable to live in a translation unit of its own, the correct thing would be to rm the file since there is no need for it anymore

Oh I see, you moved the code made on utils.c to times.c, so yeah, I too think the utils.c should be deleted. Closing this issue and creating another issue now :)