Can't download videos from YCA2015.1.2x

[yepu]

Pick the course, choose the week and it says 'WARNING: No downloadable video found.'. Commit 68d3661393f589994e1dfe382a6a37b9c23d6a43 is the culprit. Reset to 4b4578f52168c6c70de8c159f1a223c6f37a48a5 make it works again.

[iemejia]

Hello, thanks for reporting, apparently there is something different about these two courses, maybe a layout change or something, but the commits you talk about seem unrelated. I will check for this later on.

[iemejia]

I am breaking this bug into two as they are different cases.

[iemejia]

This course is a particular case, notice that the page layout is different from a regular one: YCA2015.1.2x:

Other normal course:

[iemejia]

I checked the issue and it seems that the layout is the same, but this course has only one active section so, that is why it seems weird. The fix for issue #196 allows now to dowload the videos of this course too.

[rbrito]

@yepu, After the latest changes, can you confirm that this bug is closed?

@iemejia, can you grab the HTML of the courses in question so that we can put them into our test suite?

[iemejia]

@rbrito I checked this issue in detail and it was my mistake to think that it was a layout issue. The thing is that this course has only one section, when I saw the picture I thought it had many and the script was not working, but notice that the layout is exactly the same (seldcted section has white background as well as the subsections when you have not picked a subsection), so I don't think we need a particular kind of test for this case.

Talking about tests, I wanted to suggest you the demo course as a testing scenario, since it has most of the characteristics of the platform. https://courses.edx.org/courses/edX/DemoX.1/2014/info

[rbrito]

Hi.

On May 21 2015, Ismael Mejia wrote:

@rbrito I checked this issue in detail and it was my mistake to think that it was a layout issue. The thing is that this course has only one section, when I saw the picture I thought it had many and the script was not working, but notice that the layout is exactly the same (seldcted section has white background as well as the subsections when you have not picked a subsection), so I don't think we need a particular kind of test for this case.

Ah, OK. That's "less bad". This seems to indicate that we can close this bug, then, right?

Talking about tests, I wanted to suggest you the demo course as a testing scenario, since it has most of the characteristics of the platform.

https://courses.edx.org/courses/edX/DemoX.1/2014/info

OK, great starting point. I wonder how we should put it in our repository.

With coursera, we essentially have just one page that has everything that we need, which is what I put in as "fixtures" for the unittests. For edX, the courses are generally spread over many pages and we would possibly have to download a bunch of them.

I guess that I will instrument the python code to save the pages as they are downloaded for this demo course and, then, manually inspect what was downloaded with what I see in the browser (unfortunately, this may be a tad harder due to browsers following redirects) and, finally, put all the "assets" for a given course in a directory.

If we happen to see a different kind of structure in the future, we may repeat the process for another "representative" course and put that in a separate fixture directory.

This will also make things much easier to test, since we will avoid network traffic and people from edX getting mad at us.

Thanks for the hint,

Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFCAAAA http://cynic.cc/blog/ : github.com/rbrito : profiles.google.com/rbrito DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br

[yepu]

Fixed. Thank you guys.