coursera-dl / edx-dl

A simple tool to download video lectures from edx.org (and other openedx sites)
GNU Lesser General Public License v3.0
1.93k stars 641 forks source link

Hooking up with Code Climate #250

Closed rbrito closed 9 years ago

rbrito commented 9 years ago

Just for fun and to make things faster, since I don't need special permissions on my own repositories, I decided to hook up my fork of this repository to Code Climate.

The result couldn't be better:

https://codeclimate.com/github/rbrito/edx-downloader

For comparison purposes, here is the same kind of analysis that is performed with coursera-dl:

https://codeclimate.com/github/coursera-dl/coursera

Much worse, as you can see.

We should enable this for the main repo (if we are really going somewhere with this).

Regards,

Rogério.

iemejia commented 9 years ago

wow, cool stuff, so all the refactoring work has been ok at least from those metrics, nice. @shk3 can you please assign @rbrito as the owner of the project so we can have all this nice things in the official repo. Rogerio maybe he is not following the issues, can you please write to him again.

shk3 commented 9 years ago

Do you mean transferring to an organization or his personal account? I would prefer to transfer the repo to an organization account so that all of us can do necessary work on it.

In terms of deployment hook setting, if there is anything needing me to do before we figure out an account to transfer the repo to, feel free to email me so that I can apply the necessary change as soon as possible.

George

George

On Tue, Jun 30, 2015 at 8:54 AM, Ismael Mejia notifications@github.com wrote:

wow, cool stuff, so all the refactoring work has been ok at least from those metrics, nice. @shk3 https://github.com/shk3 can you please assign @rbrito https://github.com/rbrito as the owner of the project so we can have all this nice things in the official repo. Rogerio maybe he is not following the issues, can you please write to him again.

— Reply to this email directly or view it on GitHub https://github.com/shk3/edx-downloader/issues/250#issuecomment-117236683 .

http://www.MonkeyHouse.info http://www.monkeyhouse.info/

rbrito commented 9 years ago

@shk3, you can transfer the repository to https://github.com/coursera-dl

The name may be misleading at the moment, but I can think about renaming it later.

By transferring the repository there, I can grant you guys privileges to the repository (oh, and I wouldn't mind it if any of you could also lend a hand with https://github.com/coursera-dl/coursera, as I'm having a hard time keeping up with maintenance of both projects).

@shk3, if you transfer the repo, then I will take care of renaming the repo, hooking with these services and closing all these bugs that deal with integration of code quality stuff.

shk3 commented 9 years ago

Hi @rbrito,

I am asked for admin rights when I am transferring the repo to the organization. I get the following error message: "You don't have admin rights to coursera-dl"

Would it be possible to add me and @iemejia as admin in that org? Also, it would be nice if we can rename the org as the name is indeed misleading.

shk3 commented 9 years ago

@rbrito I've received the invitation from you regarding joining coursera-dl. After joining it, I still cannot transfer the repo. I am keeping seeing the error message "You don't have admin rights to coursera-dl".

iemejia commented 9 years ago

@shk3 can't you just do the opposite and put rbrito as an admin/owner so he can move the project and that's it, I suppose he will then give you the appropriate rights for the repository in the organization.

shk3 commented 9 years ago

@iemejia, oh, I didn't think of it. Let me try it.

shk3 commented 9 years ago

@rbrito I cannot transfer this repo to you as "rbrito/edx-downloader already exists".

shk3 commented 9 years ago

Shall I rename the repo directly to "edx-dl" to finish the transfer? I am assuming it will preserve URL by redirections, right? Do we have any better plan?

The backup plan is that I can create a new org for this project, and I assume that I can grant people necessary privileges for adding hooks and adding new collaborators. However, I am fine with other better plans if any.

iemejia commented 9 years ago

Good, you can rename it, at least from the documentation github preserves the redirections. Go ahead !!! About the plan b it is not a good idea, since rogerio has an organisation and the goal is to have both projects (coursera and edx-dl) together.

When a repository is transferred, all links to the previous location are automatically redirected to the new location.
...
When you rename a repository, all existing information is automatically redirected to the new name.

from: https://help.github.com/articles/transferring-a-repository/ https://help.github.com/articles/renaming-a-repository/

shk3 commented 9 years ago

Sounds good. I will do it tomorrow and I also want to wait for Rogério's input. Just to confirm, we have agreed on edx-dl as the new name, right?

Sent from my iPhone

On Jul 12, 2015, at 12:23 AM, Ismael Mejia notifications@github.com wrote:

Good, you can rename it, at least from the documentation github preserves the redirections. Go ahead !!! About the plan b it is not a good idea, since rogerio has an organisation and the goal is to have both projects (coursera and edx-dl) together.

When a repository is transferred, all links to the previous location are automatically redirected to the new location. ... When you rename a repository, all existing information is automatically redirected to the new name. from: https://help.github.com/articles/transferring-a-repository/ https://help.github.com/articles/renaming-a-repository/

— Reply to this email directly or view it on GitHub.

shk3 commented 9 years ago

@rbrito Are you okay with this plan? I am going to rename the project to edx-dl and transfer to you, so that you can transfer the project to the org.

shk3 commented 9 years ago

Oh, actually @rbrito has a repo called "edx-dl"... We have to find a way to get around of it.

iemejia commented 9 years ago

@rbrito can you please rename or remove your edx-dl project (or the other one) so @shk3 can proceed.

shk3 commented 9 years ago

@iemejia I am actually not sure if simply renaming would work as his repo will have redirection from rbrito/edx-dl to the new name. We should do a little bit experiment.

shk3 commented 9 years ago

(the following is actually posted by @rbrito)

Hi. I'm resurfacing. :)

On Jul 06 2015, George J. SUN wrote:

Do you mean transferring to an organization or his personal account? I would prefer to transfer the repo to an organization account so that all of us can do necessary work on it.

TL;DR: Go ahead and just transfer the repository to me and I'll take care of the rest.

Long version:

I have renamed the repositories that are my forks (both edx-downloader and edx-dl) to other names and you can transfer the repository to me under whatever name that you wish and I will do these necessary things (renaming, enabling travis, enabling code climate etc.).

I will, then, transfer it appropriately to the coursera-dl organization and set us all as admins/owners/whatever of the project, so that we all have rights over it.

Then, if we worry about breaking links, then you can fork that repository to your account remove all the content and put clearly in your fork that all the development is being done at such and such repository and that users are supposed to follow the development there.

Note that we won't lose the followers whenever we transfer the repository. The message of "under a new development" or whatever is only going to be shown to new users or to those that may have not starred/followed the development or that may have bookmarked the current repo.

In terms of deployment hook setting, if there is anything needing me to do before we figure out an account to transfer the repo to, feel free to email me so that I can apply the necessary change as soon as possible.

Those are very simple, but they need some legwork that I am willing to do. I can teach you guys how to do that and you can experiment with other options and I would be glad if you teach me the things that I don't know. :)

How does all this sound?

Thanks,

Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFCAAAA http://cynic.cc/blog/ : github.com/rbrito : profiles.google.com/rbrito DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br

rbrito commented 9 years ago

On Jul 14 2015, George Monkey wrote:

@iemejia I am actually not sure if simply renaming would work as his repo will have redirection from rbrito/edx-dl to the new name. We should do a little bit experiment.

They are renamed now. Feel free to go ahead and transfer the repo whenever you like.

Thanks,

Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFCAAAA http://cynic.cc/blog/ : github.com/rbrito : profiles.google.com/rbrito DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br

rbrito commented 9 years ago

I have no idea why my long response was attributed to @shk3. Perhaps I hit a bug with github without knowing it? :)

shk3 commented 9 years ago

@rbrito That's weird... I saw you sent to me and CC to the GitHub alias. I will do the operation tomorrow. I am actually very busy this week.

shk3 commented 9 years ago

@rbrito it still does not proceed... They have too many sanity checking... "rbrito already has a repository in the shk3/edx-downloader network"

rbrito commented 9 years ago

@shk3, Oh, darn.

I just deleted my repository. I hope that it works now.

Thanks.

shk3 commented 9 years ago

Here you go! Finally. @rbrito

rbrito commented 9 years ago

Oh, let's see how things go now...

rbrito commented 9 years ago

OK, it seems to have worked. Now, to change some other things, like renaming the repo.

rbrito commented 9 years ago

OK, moved to the organization.

rbrito commented 9 years ago

OK, Renamed the repository.

rbrito commented 9 years ago

I think that linking with codeclimate worked: https://codeclimate.com/github/coursera-dl/edx-dl/

Does it work for you guys?

rbrito commented 9 years ago

It seems to be working and I just put some badges on the main documentation/README.

I think that we can close this issue, then. If I missed something, please let me know (I'm sleepy, I must have missed something).

shk3 commented 9 years ago

@rbrito Awesome! The redirection works! So do I still need to create an informative shk3/edx-downloader? I feel like it might not be necessary anymore.

rbrito commented 9 years ago

Hi, @shk3 and @iemejia.

On Jul 18 2015, George Monkey wrote:

Here you go! Finally. @rbrito

Excellent! Did you guys get any e-mail when the tests fail?

If not, can I put your e-mail addresses on the .travis.yml file? The e-mails will be publicly visible, so if you want one address in particular, please let me know.

You can see something similar in the youtube-dl file:

https://github.com/rg3/youtube-dl/blob/master/.travis.yml#L12-L16

Thanks,

Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFCAAAA http://cynic.cc/blog/ : github.com/rbrito : profiles.google.com/rbrito DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br

iemejia commented 9 years ago

Hi guys, I am really happy that this is finally over. Great work. Thanks a lot @shk3 for been generous about moving the repo, and thanks a lot to you @rbrito for always paying the best attention to details.

You can add me to the .travis.yml file.

shk3 commented 9 years ago

Thanks, @rbrito. You can go ahead to add it.