Videos names of downloaded files are different from the names on edX - Githubissues

coursera-dl / edx-dl

A simple tool to download video lectures from edx.org (and other openedx sites)

GNU Lesser General Public License v3.0

1.93k stars 640 forks source link

Videos names of downloaded files are different from the names on edX #480

Open jakemike opened 6 years ago

jakemike commented 6 years ago

Subject of the issue

edx videos names are downloaded as youtube names of the files (e.g 01-COLMLXXX2016-V012900-IcnFJs4DENs), not names shown in edx

environment

Operating System (name/version): windows 10
Python version: v3.6.4:d48eceb
youtube-dl version: 2017.12.31
edx-dl version: 0.1.7

Steps to reproduce

edx-dl -u -p -s https://courses.edx.org/courses/course-v1:ColumbiaX+CSMM.102x+2T2017/course/

Expected behaviour

file names as shown in edx

Actual behaviour

file names are not as shown in edx

rbrito commented 6 years ago

Actually, the names are not "corrupted". They are the names that the uploader gave on youtube... That's the name that we end up using. Someone can fix this, but this is a moderately low priority. Contributions are welcome.

Ankk98 commented 6 years ago

I am a beginner but I would like to work on this issue.

JohnVeness commented 4 years ago

Hello. Just for the record, I notice this problem with videos downloaded from edx-video.net too, so this isn't just a youtube problem.

Ankk98 commented 4 years ago

In this case,

In _build_url_downloads takes filename from youtube name.
Names appear to be wrong because of random youtube naming of these videos.
- An alternative approach can be to take lecture names from the website page incase of edx.

If this approach seems fine, I can work on a pr.

rbrito commented 4 years ago

@Ankk98, It's been a long, long time since I last worked on, but I can review and merge a pull request of yours. I would STRONGLY prefer IF:

it is a collection of a simple series of patches that are conceptually simple and logically independent.
it preserves the Youtube IDs (e.g., appended to the filenames). One of the main motivations of edx-dl is to be used as an archival tool that preserves references in case the videos can be downloaded again.

I may work again on edx-dl (but I'm currently, way, way more interested in coursera-dl, but my time is already spread too thin) if the code ends up simplified...