Patch Not Working it make me worse please help to patch

[nickel155]

i am using anaconda. so i have replaced the patch files in Anaconda3\Lib\site-packages\edx_dl. before patching at least it is showing the course list but downloaded 0 videos.

C:\edx-dl-master\edx-dl-master>edx-dl -u ***@gmail.com https://courses.edx.org/courses/course-v1:MITx+15.071x_2a+2T2015/course/ edx_dl version 0.1.7 Password: Building initial headers for future requests. Getting initial CSRF token. Found CSRF token. Logging into Open edX site: https://courses.edx.org/login_ajax Extracting course information from dashboard. Downloading The Analytics Edge [course-v1:MITx+15.071x_2a+2T2015/co] Downloading 0 section(s) Extracting all units information in parallel. No downloadable video found.

After patching

C:\edx-dl-master\edx-dl-master>edx-dl -u **@gmail.com --list-courses edx_dl version 0.1.7 Password: Building initial headers for future requests. Getting initial CSRF token. Found CSRF token. Logging into Open edX site: https://courses.edx.org/login_ajax Extracting course information from dashboard. You can access 0 courses

so is there any wrong in patching

[Nocxy]

You should edit to protect your personal email address.

The patch isn't resolving everything but in my case it allowed me to download videos - though it made it six times instead of one.

IMHO, rbrito was a little bit in a hurry to show "hey guys, I merged it" though the modification wasn't from him. If the person who patched didn't merge it, I'd bet it was because you cannot say for sure that a patch will correct everything - that's why nobody implements patches out-of-the-box. Rbrito probably only did it to raise his stats instead of testing it.

[anmolsahoo25]

Hi, I have submitted a pull request to fix this.

[rbrito]

On Sun, Mar 11, 2018 at 5:00 AM, Nocxy notifications@github.com wrote:

IMHO, rbrito was a little bit in a hurry to show "hey guys, I merged it" though the modification wasn't from him. If the person who patched didn't merge it, I'd bet it was because you cannot say for sure that a patch will correct everything - that's why nobody implements patches out-of-the-box. Rbrito probably only did it to raise his stats instead of testing it.

If I understand it correctly, you are volunteering to maintain edx-dl, right? In that case, I can surely step down and let you do the work, as you are probably more fit for the position.

I've been absent here for this past week EXACTLY for this very own accusation.

Listen here, fellow: I'm past my 40'ies and I should care much more on life (like fighting legally to see my own son or helping my relatives with their and my health problems) other than "my stats" on a stupid little (granted, popular) project to which I've probably devoted more time than I probably should, just to help some ungrateful users like you accuse me of needing to show anybody that I merged something (your: "hey guys, I merged it"). I'm here for a general benefit, not to show anyone of my "mad python skillz"...

Merging a fix that multiple people confirmed that was working and whose fixed problem was probably preventing other users from grabbing the material for their own study was an expedite solution that I took, without going through the bureaucracy of a long round-trip of asking for a pull request.

Furthermore, since the 3 main maintainers (@iemejia, @balta2ar and me) received a message from edX staff saying that the program probably violated their terms, we have (OK, I'm speaking here only for myself, but of probably also about them) had our enthusiasm lowered about this project.

Yet, I kept an eye here.

And I get an accusation of someone that doesn't seem to have a life or that is worried about frivolous little things like "stats" on a little website? C'mon... The world would be much better without you participating here. A original report just saying that the fix didn't work wouldn't have demotivated me. It would actually have made me fix whatever error that I may have made (if I made something).

The way that things are just made me lost more of the interest in fixing things here, instead of on coursera-dl (from which we have not received any warnings in all these years and from which we were at some point even listed in their own wiki as one of the solutions to download the videos for the students).

OK, the original message to which I am responding probably didn't merit an answer as long as this one, but I plan on referring other users of edx-dl to this answer whenever they ask me to fix their problems, so that they know who they should be asking fixes from.

Thanks for volunteering to manage the collective and community of edx-dl users,

Rogério Brito.

-- Rogério Brito : rbrito@{ime.usp.br,gmail.com} : GPG key 4096R/BCFCAAAA http://cynic.cc/blog/ : github.com/rbrito : profiles.google.com/rbrito DebianQA: http://qa.debian.org/developer.php?login=rbrito%40ime.usp.br

[rbrito]

I believe that this is fixed with the newest version of the program.

Please don't forget to update your edl-dl installation to the latest version with pip install -U edx-dl