search

coursera-dl / edx-dl

A simple tool to download video lectures from edx.org (and other openedx sites)
GNU Lesser General Public License v3.0
1.93k stars 640 forks source link

used more precise login endpoints #574

Open EugeneLoy opened 4 years ago

EugeneLoy commented 4 years ago

@balta2ar Thank you for merging #569 Based on troubleshooting from #559 there is small tweak to login endpoints that should be made in order to fix the problem for all users. This PR addresses this.

balta2ar commented 4 years ago

Since you're on it, do you think you could also take a look at https://github.com/coursera-dl/edx-dl/issues/573?

EugeneLoy commented 4 years ago

@balta2ar Ok, I'll look into it later this week.

EugeneLoy commented 4 years ago

@balta2ar Hi. I've amended this PR, so login will work on other openedx sites (ones that received no change to the login process).

This fixes #573 (fun-mooc.fr).

Note, however that this is somewhat nominal fix, as it seems that downloading video from fun-mooc.fr is broken in it's own way.

I've tried couple of courses and only resources were downloaded (not video). It looks to me that the problem is either because FUN does not host videos on youtube or something is broken with parsing FUN course pages.

Anyway, this is just a guess as I am not willing to tackle this issue.