search

coursera / courier

Data interchange for the modern web + mobile stack.
http://coursera.github.io/courier/
Apache License 2.0
98 stars 24 forks source link

Record equality should take the type of the record into account #35

Closed FireJade closed 8 years ago

FireJade commented 8 years ago

Currently, record equality delegates to ScalaRunTime._equals, which takes only the elements of the record into account and not its productPrefix or type. We additionally check canEqual, which uses isInstanceOf, to ensure that the types can be equal.

saeta commented 8 years ago

This LGTM.