coursera / courier

Data interchange for the modern web + mobile stack.
http://coursera.github.io/courier/
Apache License 2.0
98 stars 24 forks source link

Removed unneeded imports. Checked-in module config #78

Open alexozdemir-coursera opened 6 years ago

alexozdemir-coursera commented 6 years ago

Why check in the module configuration? It turns out that IDEA does a bad job of importing plugin modules from source. In particular, it fails to recognize them as plugin modules at all, thinking instead that they're just plain Java. The consequence of this mis-identification is that the build configurations get messed up, making it impossible to build your plugin. The manual procedure to fix this mis-identification is cryptic, so there's a clear benefit to checking in the project files.

Why would you not check in the module files?

There is also a small bugfix in here: because the resources folder wasn't properly identified (again, because import-from-source is no good) the template creation actions broke. I've rebuilt the plugin and modified the now-checked-in module file includes the relevant resource-folder registration.