search

coursera / coursera-labs

Apache License 2.0
18 stars 24 forks source link

Better to use `USER $NB_UID` rather than `USER $NB_USER`? #14

Closed echuber2 closed 4 years ago

echuber2 commented 4 years ago

I was comparing the base images with Jupyter's, and I noticed that at the end of most of the dockerfiles here, you have:

USER $NB_USER

For consistency with the base Jupyter images (and maybe better security in future orchestrations), would it be better to have:

USER $NB_UID

But there's no need to change things like WORKDIR /home/$NB_USER/work, where the username is definitely needed.

For reference, see how this issue was resolved: https://github.com/jupyter/docker-stacks/issues/549

echuber2 commented 4 years ago

Closing this. It probably doesn't matter for deploying on Coursera Labs.