search

coursera / dataduct

DataPipeline for humans.
Other
252 stars 82 forks source link

Fix autocommit #123

Closed zhaojunz closed 9 years ago

zhaojunz commented 9 years ago

Reviewers: sbajaj

CC:

Test Plan: no test yet, going to test it tomorrow before the merge

Auditors:

zhaojunz commented 9 years ago

@sb2nov ptal

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 69.53% when pulling f0baae2ae8076276ddb724a8f0e8754cf130f9e4 on zzj-fix-autocommit into 20ddfc3a4325d7961ed1534dc46b15840481a48d on develop.

sb2nov commented 9 years ago

This is actually bad for things like upsert as that wipes the table clean before loading data. So you want that to be one transaction.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.05%) to 69.48% when pulling b33fdc6f9ee6267ccb85e4752258802fe62ddea3 on zzj-fix-autocommit into 20ddfc3a4325d7961ed1534dc46b15840481a48d on develop.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-0.05%) to 69.48% when pulling dbd9e68924bf107e12595b7ab8a2c926d7b2d20a on zzj-fix-autocommit into 20ddfc3a4325d7961ed1534dc46b15840481a48d on develop.