coursera / dataduct

DataPipeline for humans.
Other
252 stars 82 forks source link

Ec2resource vpc options #132

Closed kskucha closed 9 years ago

kskucha commented 9 years ago

Added the ability to pass in securityGroupIds and subnetId to EC2Resource to enable VPC launching the EC2 resource in a non-default VPC as described here: http://docs.aws.amazon.com/datapipeline/latest/DeveloperGuide/dp-object-ec2resource.html

Tested on our own pipeline.

sb2nov commented 9 years ago

Hi, I think you're trying to create a new release on master. We generally try to merge from develop to master and I think I merged the changes in your commit into develop already.

I can create a new release of dataduct over the weekend from the develop branch. If that works should I close this PR ?