Comments like `/* A /* B */` are not removed correctly

coursera / dataduct

DataPipeline for humans.

Other

252 stars 82 forks source link

Comments like `/* A /* B */` are not removed correctly #134

Closed jhorowitz-coursera closed 9 years ago

jhorowitz-coursera commented 9 years ago

It appears that the comment-removal code in https://github.com/coursera/dataduct/blob/master/dataduct/database/parsers/transform.py#L50 will transform:

/* A /* B */

into

/* A

when it should really remove the entire thing.

sb2nov commented 9 years ago

Won't fix as this doesn't seem that important and comments should be written in some other fashion. Also even pyparsing's native cStypeComment parser doesn't support this case.

Added more tests to mark this as unresolved in #183