search

coursera / dataduct

DataPipeline for humans.
Other
252 stars 83 forks source link

Added multiple frequency options #136

Closed zen-mychen closed 9 years ago

zen-mychen commented 9 years ago

Enable the options to choose frequency of multiple hours, days, or weeks as described for "period" at http://docs.aws.amazon.com/datapipeline/latest/DeveloperGuide/dp-object-schedule.html

Tested on our own pipeline

sb2nov commented 9 years ago

Actually I think 2-days might be a better name than 2-daily as that is more intuitive so may be we can come up with something like that. Thoughts ?

tpcstld commented 9 years ago

2-days sounds better than 2-daily. We should also add 1-day, 1-week, etc... as well to the map then as aliases.

Has it been considered to do everything in hours/minutes for the ultimate consistency? I.e. pass in 24 hours instead of 1 day, 168 hours instead of 1 week.

zen-mychen commented 9 years ago

Modified to include the nice comments. Does everything in hours/minutes may bring a conversion every time people put the frequency?

tpcstld commented 9 years ago

I was wondering if we could just send "12345 minutes" in the API call and have AWS figure it out themselves. It's not important. (:

Anyways, LGTM. ~

sb2nov commented 9 years ago

Thanks for the change @zen-mychen