search

coursera / dataduct

DataPipeline for humans.
Other
252 stars 82 forks source link

Typo in passing minutes to schedule class #201

Open everanurag opened 8 years ago

everanurag commented 8 years ago

Line 188 in etl_pipeline (https://github.com/coursera/dataduct/blob/develop/dataduct/etl/etl_pipeline.py) passes variable "load_min" as minute component of specified schedule time from YAML file. However, in line 52 of schedule class (https://github.com/coursera/dataduct/blob/develop/dataduct/pipeline/schedule.py), it expects it as "load_minutes" which is initialized to None. Hence minute component is never passed correctly from YAML file and is always initialized to 0.

Fix: Change line 188 in etl_pipeline to "load_minutes"

sb2nov commented 8 years ago

@everanurag thanks for reporting, I'll try to send out a fix soon.

zerowgravity commented 8 years ago

Any update on this? As a workaround, I've overridden the minutes attribute in schedule.py. Otherwise it is really hard to test an on-demand pipeline at an arbitrary timestamp.