search

coursera / dataduct

DataPipeline for humans.
Other
252 stars 82 forks source link

supporting RDS Postgres #204

Closed kpx-dev closed 8 years ago

kpx-dev commented 8 years ago

If I want to have Postgres support in dataduct (or is it already supported? sorry I'm new to dataduct), do I create something like this? https://github.com/coursera/dataduct/blob/develop/dataduct/pipeline/mysql_node.py

Thanks!

sb2nov commented 8 years ago

You're right we'll have to create something like that. Ideally we would want to move from the mysql_node to a generic sql_node (http://docs.aws.amazon.com/datapipeline/latest/DeveloperGuide/dp-object-sqldatanode.html).

kpx-dev commented 8 years ago

I see, so create parent class like: SqlNode then make MysqlNode and PostgresNode inherit from it? If you are cool with this support, I'll try to submit such PR?

sb2nov commented 8 years ago

Yeah that makes sense, feel free to send in a PR.