search

coursera / dataduct

DataPipeline for humans.
Other
252 stars 82 forks source link

make -f default, #236

Closed cliu587 closed 8 years ago

cliu587 commented 8 years ago

and add -nf or --no-force flag to get the current behavior of creating a second pipeline with the same name

PTAL @sb2nov, I think -f is the more intuitive behavior, so we have made this the default.

coveralls commented 8 years ago

Coverage Status

Changes Unknown when pulling 8b403b0bfb1909ef4ed5010a6fac92c74c0685c9 on cliu_force_option_by_default into \ on develop**.

tpcstld commented 8 years ago

If I can chip in my 2 cents, I feel that the safety from setting no force by default outweighs whatever advantages force by default gives.

Anyways, if this does get merged, beware that this is a breaking change. (Maybe increment major version number?)

cliu587 commented 8 years ago

As pipelines are scoped by name, having two pipelines with the same name may cause undefined behavior. I'm not sure if there's a case when I want two pipelines with the same name to exist.

And can you elaborate a bit more on why it's a breaking change?

tpcstld commented 8 years ago

Some users may have depended on the fact that the default option is no-force. (e.g. when running dataduct from an external script.)

sb2nov commented 8 years ago

I think I agree with the fact that this is a breaking change but I don't think in the long experience with dataduct we've rarely found it useful to run without -f.

We should bump the version number though after this and make a new release.