search

coursera / dataduct

DataPipeline for humans.
Other
252 stars 83 forks source link

CLUSTER_ID is required for Redshift shell to work. #256

Open eldhosejohn opened 7 years ago

eldhosejohn commented 7 years ago

We are currently selecting either CONNECTION_STRING or CLUSTER_ID. This will cause error when try to run redshift shell ('dataduct sql_shell redshift') using jdbc connection string, as this requires CLUSTER_ID. Modified the code to pick the CONNECTION_STRING if both fields are available. This will make the sql shell to work.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 63.908% when pulling ef60d9db72d5fb8de01856c6360aa7b649465c74 on eldhosejohn:fix_redshift_shell into 69b539e64357a902dd9b10e682463f49482b4642 on coursera:develop.

eldhosejohn commented 7 years ago

This commit is connected with the following PR - https://github.com/coursera/dataduct/pull/255. Here CLUSTER_ID is not considered (skipped) when CONNECTION_STRING is in use (i.e when connecting to Redshift hosted outside VPC). However CLUSTER_Id is required for the redshift shell (psql command) to work.

I am currently using dataduct in production. @sb2nov