search

coursera / metrics-datadog

metrics-datadog
Other
187 stars 105 forks source link

Allow tag values which contain delimiter #106

Closed jsurls closed 1 year ago

jsurls commented 5 years ago

According to Datadog documentation a key:value which contains a value where a ':' resides is a legal value. Datadog splits on the first ':'. Added logic to allow for this in TagUtils. I also added unit tests and negative tests.

image

See also: https://docs.datadoghq.com/tagging/

jsurls commented 5 years ago

I should note.. I ran into this when implementing the DynamicTagsCallback to fetch ECS Metadata and pass along the task ARN. The datadog container running as a sidecar is supplying task level metrics utilizing the tag format of task_arn:arn:aws:ecs:region:aws_account_id:container-instance/cluster-name/container-instance-id

jhohertz commented 5 years ago

Just wanted to note, seeing as this project appears to be abandoned, I am going to try to continue development over here: https://github.com/viafoura/metrics-datadog

The package space has been renamed, this pending PR has been merged, and we've released a 2.0.0-RC2 to maven central.