coursier / sbt-shading

Apache License 2.0
33 stars 10 forks source link

ShadingPlugin: use full deps, including platform #30

Closed kitbellew closed 1 year ago

kitbellew commented 1 year ago

Otherwise, native and sjs dependencies will not be found and included in the output jar.

kitbellew commented 1 year ago

@alexarchambault @guizmaii @tgodzik please review, merge and release :)

kitbellew commented 1 year ago

@tgodzik i built a local snapshot and used for the scalameta build, and the sjs jar was built correctly. no other testing.

kitbellew commented 1 year ago

@tgodzik @alexarchambault added scripted tests.

as usual (with me), please review one commit at a time; each commit passes all tests.

kitbellew commented 1 year ago

@tgodzik how comfortable are you merging and then releasing this? I'm less worried about the change itself but previous release failed to publish, not sure if it was a temporary error.

tgodzik commented 1 year ago

@tgodzik how comfortable are you merging and then releasing this? I'm less worried about the change itself but previous release failed to publish, not sure if it was a temporary error.

We'll need to have a look then. Let's merge this for now

kitbellew commented 1 year ago

@tgodzik @alexarchambault https://github.com/coursier/sbt-shading/actions/runs/5655097359/job/15319591503

[info] gpg: no default secret key: No secret key
[info] gpg: signing failed: No secret key
Error:  java.lang.RuntimeException: Failure running 'gpg --batch --pinentry-mode loopback --passphrase *** --detach-sign --armor --use-agent --output /home/runner/work/sbt-shading/sbt-shading/target/scala-2.12/sbt-1.0/sbt-shading-2.1.3.pom.asc /home/runner/work/sbt-shading/sbt-shading/target/scala-2.12/sbt-1.0/sbt-shading-2.1.3.pom'.  Exit code: 2

strange. ci.yml hasn't changed much since https://github.com/coursier/sbt-shading/commit/84f11df179ee3f4237b3d06f5465929b9595aa27 but this gpg part seems to have stopped working. did the secret get deleted?

tgodzik commented 1 year ago

I don't have access to secrets so not sure if it exists or is incorrect. We'll need Alexandre's help here.

kitbellew commented 1 year ago

@alexarchambault is this something you could help with? @tgodzik and i can't figure out why the publish job continues failing, so we can't release any versions of this plugin.

kitbellew commented 1 year ago

@tgodzik @alexarchambault ok, we are officially stuck. i somehow imagined that a snapshot would be sufficient, and today it has vanished, with all scalameta builds promptly failing. @alexarchambault is there any way you could help with releasing this?

alexarchambault commented 1 year ago

So the release is ongoing. Seems https://github.com/coursier/sbt-shading/commit/59a67058fada300fe7f4ae15bde250810a6e4e40 fixed the GPG issues (alongside with an earlier update of the key and secret).

kitbellew commented 1 year ago

@alexarchambault thank you!

tgodzik commented 1 year ago

Thanks!