search

coursier / sbt-shading

Apache License 2.0
33 stars 10 forks source link

Empty namespaces need to be added to `validNamespaces` #4

Open tomasherman opened 3 years ago

tomasherman commented 3 years ago

Hello,

Thanks for this plugin! I'm trying to use shading in one of our project and it seems that empty packages must be added to validNamespaces. Is that intended?

It seems to lead (at least in my case) to adding packages like com and org and io to the validNamespaces, which kinda defeats the point of this validation in my opinion as it will whitelist pretty much anything. Am i missing something?

I think it would make sense to apply validNamespaces only to filenames, not directories.

guizmaii commented 1 year ago

Agreed. Just bumped into the same issue.