Use JJProcessor from jarjar-abrams

coursier / sbt-shading

Apache License 2.0

33 stars 10 forks source link

Use JJProcessor from jarjar-abrams #47

Closed williamyaoh closed 5 months ago

williamyaoh commented 5 months ago

Hello, I noticed that sbt-shading appears to be using the MainProcessor from jarjar, which means it doesn't shade Scala JARs properly, only Java JARs; the Scala metadata in the compiled classes ends up with the wrong package name. Since jarjar-abrams is already a dependency, would it be possible to change it to use the JJProcessor from jarjar-abrams instead?

tgodzik commented 5 months ago

That looks like something I actually encountered in the wild. @alexarchambault what do you think about merging the change?

alexarchambault commented 5 months ago

Sure, if that allows the Scala metadata to be updated, definitely

alexarchambault commented 5 months ago

@tgodzik You have enough rights to merge and cut a release, right?

tgodzik commented 5 months ago

Yes! I just wasn't super sure about the consequences of the change 😅