cout970 / Magneticraft-API-and-Issues

Some place to issues and bug reports
6 stars 1 forks source link

[Suggestion] MineTweaker Support Documentation #15

Open angelnc1989 opened 9 years ago

angelnc1989 commented 9 years ago

MineTweaker support for Magneticraft machines would be great to alter certain recipes for packs. It would be nice if you considered it.

cout970 commented 9 years ago

The mod is already compatible with MineTweaker

angelnc1989 commented 9 years ago

Is there any documentation? It didn't find it on the MineTweaker wiki.

Cypher121 commented 9 years ago

There's no documentation yet, but we'll make it a bit later.

Yulife commented 9 years ago

I could do it if the mod was open source. Any plans on it doing so soon? Would help a ton.

Cypher121 commented 9 years ago

Well, that's not for me to decide, but I'm all for it. BTW, stub documentation is here: https://github.com/cout970/Magneticraft-API-and-Issues/wiki/MineTweaker-3-Integration

Yulife commented 9 years ago

MT Documentation doesn't belong to a Github wiki but to the public MT wiki where almost all mods are documented. Please look at other examples if you want to re-do it for formatting :)

Cypher121 commented 9 years ago

Yeah, but I don't have access to it and no idea how to get it.

Yulife commented 9 years ago

I can do it once the source code is free but for future reference, it's pretty easy to make a wiki account and edit. :grimacing:

Cypher121 commented 8 years ago

Except this wiki doesn't accept my Wikia account and there's ABSOLUTELY ZERO information on how to create account specifically for that. And there are only 3 active users. I assume this wiki is not for public editing at all, so I'll continue with something reliable. I plan on getting it done this week finally.

Yulife commented 8 years ago

Seriously? lol. I never had a wiki account and that was my first one. Just say no, I can do the doc but bringing on excuses is worse :stuck_out_tongue_winking_eye:

Yulife commented 8 years ago

Alright, during the documenting I noticed a few things:

-There is a meta data parameter in all the ZenMethods of the Thermopile, which is kind of redunant since you can include the meta data in the Block in the first parameter

-Thermopiles ZenMethods do not work at all and throw weird errors although I did it correctly: Here's the script and error:

Script:

//Thermopile //InputBlock, Meta, TemperatureAmount mods.magneticraft.Thermopile.addHotSource(Magneticraft:blockhotcrude, 4, 100); //InputBlock, Meta, TemperatureAmount mods.magneticraft.Thermopile.addColdSource(minecraft:packed_ice, 0, 100); //InputBlock, Meta mods.magneticraft.Thermopile.removeHeatSource(minecraft:ice, 0);

MT Log:

ERROR: magneticraft.zs:51 > a method available but none matches the parameters (minetweaker.item.IItemStack, int, int) ERROR: magneticraft.zs:53 > a method available but none matches the parameters (minetweaker.item.IItemStack, int, int) ERROR: magneticraft.zs:55 > a method available but none matches the parameters (minetweaker.item.IItemStack, int)

Interesting is, on startup the script throws the errors. However, if you reload, it successfully loads but still does not work.

Cypher121 commented 8 years ago

You aren't giving it a block, you're giving it an IItemStack. It expects IBlock. I'm not sure how to convert between them, there isn't much documentation on it. Also that's a reason for meta argument

Yulife commented 8 years ago

Try to use IIngredient instead of IBlock. The Pure Daisy handler uses it as well although it's in world Also, could you give the reason? In Minetweaker meta is handled via a ":[number]" in the bracket.

Cypher121 commented 8 years ago

OK, I'll see what I can do about it. And I filled in half of GitHub wiki page, probably will finish today.

Yulife commented 8 years ago

So could you remove the meta parameter? It's not necessary. Also, it'd be great if you add the @'Optional annotation to the following parameters: (they will be bolded)

//Crusher //InputStack, OutputStack1, OutputStack2, OutputStackChance2, OutputStack3, OutputStackChance3

//Grinder //InputStack, OutputStack1, OutputStack2, OutputStackChance2, OutputStack3, OutputStackChance3

//Refinery (Not sure about this one) //InputFluid, OutputFluid1, OutputFluid2, OutputFluid3

//Sifter //InputStack, OutputStack1, OutputStack2, OutputStack2Chance

Thanks in advance :wink:

Fortist commented 7 years ago

The Thermopile additions dont work, at all. Tried a "fluiddict" liquid, the liquid block itself, and even tested vanilla blocks. Kept throwing the above errors of "iItemstack" and some such.

bookerthegeek commented 7 years ago

Heyo!

Just a quiet little bump asking for an update to the documentation posted over here with the updated syntax for the MineTweaker scripts please? More specifically updating the page to include all the machines with Minetweaker Support.

Thank you for taking the time to read my request. :)

MechWarrior99 commented 7 years ago

It is up to date as far as I know. 1.10.2 does not currently have CrafTweaker support. That page is only for 1.7.10 and that is all the machines that have minetweaker support.

bookerthegeek commented 7 years ago

Gotcha, thanks for the quick response. Any way in 1.10 to modify machine recipies? Say for making plates?

MechWarrior99 commented 7 years ago

Nope, still just trying to get another release out :P

bookerthegeek commented 7 years ago

Hey I understand. No worries and keep up the great work.