search

cov-lineages / pangolin-data

Repository for storing latest model, protobuf, designation hash and alias files for pangolin assignments
GNU General Public License v3.0
27 stars 2 forks source link

Why delay releases via pre-releases if GISAID does not apply newest release for a few days-weeks anyways? #27

Closed corneliusroemer closed 1 year ago

corneliusroemer commented 1 year ago

I've noticed that you seem to delay the full release of pangolin-data, doing a pre-release first, with the argument being that this allows GISAID to be able to update their lineages ahead of the release.

I've just checked and GISAID is not using the newest version v1.15.1 for the very newest uploads despite the prerelease having occurred a few days ago.

Here you can see that v1.14 is still used (I remember that v1.14 started being used only weeks after the official release by GISAID, despite pre-release):

image

So the argument of allowing GISAID a few days to sync appears not to be very convincing, at least at the moment.

I'm wondering whether this delay is more harmful than beneficial as it further delays the appearance of new important lineages like BQ.1.1, XBB etc. for pangolin users who do not use GISAID's annotation but run pangolin directly.

corneliusroemer commented 1 year ago

Here's the reasoning for the delay:

We haven't tagged a new pangolin data release yet, the latest one is still 1.14. Will tag it later today, just giving GISAID the time to update prior to tagging the release

Originally posted by @aineniamh in https://github.com/cov-lineages/pango-designation/issues/1199#issuecomment-1273392408

aineniamh commented 1 year ago

We no longer do a pre-release but we now merge to master ~12 hours before tagging the release. This was the agreement we had with them to give some heads up for starting the re-assignment process. It's no big deal on our end to wait 12 hours if it's something that is helpful to GISAID.

Maybe contact them if you think it's worth revising that schedule?

corneliusroemer commented 1 year ago

Thanks @aineniamh, I wasn't aware this was just 12 hours, in that case it isn't worth discussing. Thanks for clarifying!