search

covalenthq / goldrush-kit

Beautifully designed React components for web3 dApp frontend. Easily fetch data from 200+ blockchains. Open-source. Customizable.
https://goldrush-kit.vercel.app/
Apache License 2.0
95 stars 46 forks source link

Click events on NFT wallet view #162

Closed wtracy closed 4 months ago

wtracy commented 5 months ago

Right now, I don't a way to register click events on the NFT wallet component without actually modifying the component code. Am I reading this right?

If I wanted to add click event support and have the change merged back, does the team have any strong opinions on how this should be implemented?

jagnani73 commented 5 months ago

You are reading this right, we are working on adding click functions to the Organisms

There aren't any strong opinions if you want to contribute to the code. You can refer to this and how this is implemented.

There are tests for proper linting that need to be passed before merging the code and thats it!

jagnani73 commented 4 months ago

Hey @wtracy This feature is added, you can use actionables like in the [https://goldrush-kit.vercel.app/?path=/story/organisms-nft-collection-view--nft-collection-view](urlstorybook

wtracy commented 4 months ago

Thanks!

I have it working with my local copy, and haven't had a chance to get it cleaned up and submit a pull request.

William

On Wed, May 29, 2024, 1:44 PM Yashvardhan Jagnani @.***> wrote:

Hey @wtracy https://github.com/wtracy This feature is added, you can use actionables like in the [ https://goldrush-kit.vercel.app/?path=/story/organisms-nft-collection-view--nft-collection-view](urlstorybook

— Reply to this email directly, view it on GitHub https://github.com/covalenthq/goldrush-kit/issues/162#issuecomment-2138232192, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAARYQK7BTEHWLKGEGN5NW3ZEY42PAVCNFSM6AAAAABG6BO2XSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZYGIZTEMJZGI . You are receiving this because you were mentioned.Message ID: @.***>