Open alexprudhomme opened 1 week ago
:white_check_mark: Title follows the conventional commit spec.
File | Old (kb) | New (kb) | Change (%) |
---|---|---|---|
case-assist | 235.9 | 235.9 | 0 |
commerce | 339.1 | 339.1 | 0 |
search | 409.5 | 409.5 | 0 |
insight | 395.4 | 395.4 | 0 |
recommendation | 248.5 | 248.5 | 0 |
ssr | 403.5 | 403.5 | 0 |
ssr-commerce | 351.4 | 351.4 | 0 |
Use case | SSR (#) | CSR (#) | Progress (%) |
---|---|---|---|
search | 39 | 44 | 89 |
recommendation | 0 | 4 | 0 |
case-assist | 0 | 6 | 0 |
insight | 0 | 27 | 0 |
commerce | 0 | 15 | 0 |
I was able to make a script with the zx library to test attw as well. In this one, I am testing headless and filtering out the FalseESM errors. Let me know if you think we should add this.
@alexprudhomme as discussed in person, I don't think we should run attw checks in our CI until our packages are clean enough that we aren't forced to filter out "false" positives all over the place in the attw report. Hopefully by then the attw CLI will have evolved to be more CI-friendly, or better yet they'll have released an npm library that does what we need.
https://coveord.atlassian.net/browse/KIT-3596