search

coveooss / spillway

A simple, distributed and flexible rate limiter
MIT License
34 stars 12 forks source link

Add limit overrides and test #17

Closed Sytten closed 8 years ago

Sytten commented 8 years ago

This changes was necessary for us because we wanted to have different limits for some organizations while maintaining a base limit when no override is specified. This was hardly possible before because it would require to maintain multiple spillway objects and knowing each one was related to what organization.

malaporte commented 8 years ago

Some general comment - it would have been nice to have a short justification in the PR description of why this change is being introduced. I'm still somewhat guessing why it's really needed, in fact...

Sytten commented 8 years ago

I just added one

Sytten commented 8 years ago

@GuiSim @malaporte I just added the clocks, its working great. The only test who can't use it is the embedded redis, but I feel it is more a FT than a UT... Maybe we should move those long tests elsewhere and mark them as FT?