Update golang parser regex

coverallsapp / coverage-reporter

Self-contained, universal coverage uploader binary. Under development.

https://coveralls.io

MIT License

49 stars 17 forks source link

Update golang parser regex #141

Closed kjstouffer closed 1 month ago

kjstouffer commented 1 month ago

:zap: Summary

I updated go to go 1.22 and noticed that CI was failing to upload test coverage to coveralls. I discovered that coveralls was detecting the file type as lcov when it should have been golang. This was because the regex in the golang parser expected three slashes in the file path for each file under test.

I updated the regex to only have one slash be required, while ensuring that existing tests didn't fail. I added two new fixture files and added two new tests to ensure the new behavior works correctly.

:ballot_box_with_check: Checklist

[X] Add specs

afinetooth commented 1 month ago

Thank you, @kjstouffer!

We aim to review and merge this week after a new planned release.

kjstouffer commented 1 month ago

Hello @afinetooth! Any updates here?

afinetooth commented 1 month ago

@kjstouffer we have been working on that same release and have faced some challenges.

Therefore, I'm reviewing right now and will merge and cut a new release as soon as everything looks 👍 ...

coveralls-official[bot] commented 1 month ago

Pull Request Test Coverage Report for Build 10392646012

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 93.983%

Totals
Change from base Build 10362720696:	0.0%
Covered Lines:	906
Relevant Lines:	964

💛 - Coveralls

afinetooth commented 1 month ago

Checks passed and changes have been merged.

Give me 30 min or so to cut the new release. I need to revert some CI/CD changes related to the other release we're working on.

afinetooth commented 1 month ago

OK @kjstouffer, changes pushed to new release 0.6.14: https://github.com/coverallsapp/coverage-reporter/releases