coverallsapp / coverage-reporter

Self-contained, universal coverage uploader binary. Under development.
https://coveralls.io
MIT License
45 stars 14 forks source link

Problems with paths #44

Closed jnyrup closed 1 year ago

jnyrup commented 1 year ago

What was wrong?

When trying to upgrading to coverallsapp/github-action@v2 the paths on coveralls.io are not mapping to the source files. Since v2 changed to this project I'm guessing that this is the right place to report, please let me know if I'm wrong about that.

Is this the problem described in #41?

From the logs shown below I'm guessing the paths might need to converted into POSIX paths when running on Windows?

Logs

v1.1.3 https://coveralls.io/builds/58262714/source?filename=Src%2FFluentAssertions%2FFluentActions.cs image output from node-coveralls cat .\TestResults\reports\lcov.info | coveralls -v

"source_files": [{
    "name": "Src/FluentAssertions/AggregateExceptionExtractor.cs",

v0.2.17 github-actions uploaded lcov-file

https://coveralls.io/builds/58241348/source?filename=%5CSrc%5CFluentAssertions%5CFluentActions.cs image output from coverage-reporter coveralls-windows.exe -r [token] --dry-run --debug .\lcov.info

"source_files": [
  {
    "name": "C:\\dev\\fluentassertions\\Src\\FluentAssertions\\AggregateExceptionExtractor.cs",
jnyrup commented 1 year ago

Running CI on Windows does not work https://coveralls.io/builds/58476950/source?filename=%5CSrc%5CFluentAssertions%5CExecution%5CDefaultAssertionStrategy.cs image

Running CI on Linux works https://coveralls.io/builds/58477085/source?filename=Src%2FFluentAssertions%2FExecution%2FDefaultAssertionStrategy.cs image

mrexox commented 1 year ago

Hey! Thank you for the issue! There is indeed a path transformation in node-coveralls. I've tried to implement a similar approach in coverage-reporter. Unfortunately I don't have a Windows machine to test it. I'll appreciate if you could provide some feedback after I release this fix.

mrexox commented 1 year ago

@jnyrup, a fix is available now. If you use github action v2 or download a binary from the latest release, it should use the fixed version.

Please, come back with any feedback :)

jnyrup commented 1 year ago

Thanks for the fix - it works 🎉