coveralls-official[bot]
commented
1 year ago Pull Request Test Coverage Report for Build 4818077640
- 9 of 9 (100.0%) changed or added relevant lines in 3 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.04%) to 90.602%
| Totals | |
|---|---|
| Change from base Build 4817307153: | 0.04% |
| Covered Lines: | 723 |
| Relevant Lines: | 798 |
:zap: Summary
Previous upgrade to 1.8 failed because of PCRE2 behavior. It raises an exception if non-UTF character is met in a string. It always expects UTF, since strings in Crystal are always UTF. See https://crystal-lang.org/api/1.8.1/Regex.html for more.
In this PR I add MATCH_INVALID_UTF flag for most of regular exceptions (that are applied to data read from a file). With this approach no errors should be raised.