search

coverallsapp / github-action

Coveralls Github Action
https://coveralls.io
MIT License
458 stars 76 forks source link

suggest always passing `finish` step in README? #120

Closed vtjnash closed 1 year ago

vtjnash commented 2 years ago

This seems like the intended behavior of parallel-finished. It means parallel-finished might run multiple times if the user explicitly re-runs failed jobs, but means partial coverage will get updated once all of the CI runs end (even if few or none of them succeeded and uploaded coverage).

I wasn't certain if this should suggest only doing this for always() && github.event_name == 'pull_request', or some other combination of options, depending on how the diff-changed algorithm works across partially-failed builds. But this seemed like a simple enough improvement regardless.

mrexox commented 1 year ago

Thank you! I've added this fix in a recent PR