search

coverallsapp / github-action

Coveralls Github Action
https://coveralls.io
MIT License
458 stars 76 forks source link

Address github actions deprecation warnings. #137

Closed pmienk closed 1 year ago

pmienk commented 1 year ago

Resolves #132 and #135

RobinTail commented 1 year ago

I wonder why node_modules is committed into the repo. I believe it shouldn't be like that.

pmienk commented 1 year ago

@RobinTail - Required for github actions as documented.

See Creating a Javascript Action.

RobinTail commented 1 year ago

@RobinTail - Required for github actions as documented.

See Creating a Javascript Action.

I see exactly the opposite recommendation in the article you mentioned

Checking in your node_modules directory can cause problems. As an alternative, you can use a tool called @vercel/ncc to compile your code and modules into one file used for distribution.

@pmienk

RobinTail commented 1 year ago

I made some actions myself, and followed those recommendations on using ncc. There're also rollup and tsup suitable. Kindly suggesting you to consider committing the compiled js instead of node_modules.

pmienk commented 1 year ago

Sounds like a worthwhile modification, and if you have experience with it I would happily take a working pull request.

It was not within the scope of my concern, namely fixing the problems referenced by this pull. As such I followed the path laid out by the originating repository.

robinbowes commented 1 year ago

It seems like using something like @vercel/ncc is preferred, but that is not in the scope of this PR, so should be fixed separately, IMO.

RobinTail commented 1 year ago

omg, it's already 2023 but these warnings are still unfixed.

mrexox commented 1 year ago

I tried to fix all the warnings in @v1.2.1 release which is also available as @v1. I think this PR can be closed. Please, feel free to open a new one or ping me here if you notice something unfixed.