coverallsapp / github-action

Coveralls Github Action
https://coveralls.io
MIT License
458 stars 76 forks source link

Upgrade all libraries and required nodejs version #139

Closed robsonpeixoto closed 1 year ago

robsonpeixoto commented 1 year ago

This is a big PR, my bad 😞 , that:

This github-action still have some problems:

Everything was copied from https://github.com/actions/typescript-action

jrfnl commented 1 year ago

Duplicate of #137 ?

franky47 commented 1 year ago

Might as well use Node 18 for actions, as it's now the current LTS.

robsonpeixoto commented 1 year ago

Only node12 and node16 are supported. Reference: https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#runsusing

robsonpeixoto commented 1 year ago

@jrfnl is not duplicate of https://github.com/coverallsapp/github-action/pull/137, because this PR is a big refactor on the build process. I updated the PR description to make clear what I did.

paescuj commented 1 year ago

upgrade all dependencies

Did you forget to commit the package.json & package-lock.json files?

robsonpeixoto commented 1 year ago

Did you forget to commit the package.json & package-lock.json files? @paescuj, read the commits below:

paescuj commented 1 year ago

Did you forget to commit the package.json & package-lock.json files? @paescuj, read the commits below:

Ah, great! Sorry, it didn't show up in the diff because it's limited to 3.000 files :-)

robsonpeixoto commented 1 year ago

Sorry! Delete the node_modules created a huge diff.

paescuj commented 1 year ago

Sorry! Delete the node_modules created a huge diff.

Definitely not your fault 😃

fluxsauce commented 1 year ago

This is amazing, thank you for working on this @robsonpeixoto !

PaulRBerg commented 1 year ago

Any ETA on when this PR will be reviewed and merged by the @coveralls team?

robsonpeixoto commented 1 year ago

ping @nickmerwin @anjin

CoreyGahafer commented 1 year ago

@nickmerwin or @anjin can this be merged in?

nopeless commented 1 year ago

Hoping this will be merged soon so I don't have to see warnings :)

szepeviktor commented 1 year ago

@afinetooth Maybe we need someone to maintain this repo once a month. What do you think?