search

coverallsapp / github-action

Coveralls Github Action
https://coveralls.io
MIT License
458 stars 76 forks source link

Source not available for Windows paths ( \ ) #162

Closed luttje closed 1 year ago

luttje commented 1 year ago

Hi there,

First of all thanks for this great service to (open-source) projects, much appreciated!

I've run into a problem with paths on Coveralls: When using coverlet for a .NET project, paths on Windows get saved in the .lcov file as is. For example: C:\...etc...\Key2Joy\Output.cs. This becomes a problem when the coveralls github-action sends the path like that (my workflow). Because although the file will be listed on Coveralls (with correct coverage information), Coveralls isn't able to link to the repo source, even though it is there

image

If Windows-style paths are not valid according to some LCOV standard, then I guess I should report this in the coverlet repo. Though I'm having trouble finding exact specifications on the LCOV format. Or perhaps this github action isn't the right place, but Coveralls website support is, since other Coveralls integrations may also have this problem?

Would be happy to hear some thoughts on where the problem should be reported, or if some feature exists to translate these paths (and I've completely missed it).

Thanks in advance!

mrexox commented 1 year ago

Hey! The problem was just resolved for this issue: https://github.com/coverallsapp/coverage-reporter/issues/44. New coverage-reporter should be available for github action v2. Please, rerun the workflow which had this problem. Will be waiting for your feedback :pray:

luttje commented 1 year ago

I had missed that issue. Replying to confirm that it works great now.

Thanks for the swift response! ✌