search

coverallsapp / github-action

Coveralls Github Action
https://coveralls.io
MIT License
463 stars 75 forks source link

Support GitHub Actions ARM runners #218

Open aaomidi opened 1 month ago

aaomidi commented 1 month ago 
/home/runner/work/_temp/b1d5f4e4-9e42-492a-b074-ae4e66c473a0.sh: line 1: /home/runner/bin/coveralls: cannot execute binary file: Exec format error
afinetooth commented 1 month ago

@aaomidi We are working on this right now and hope to deliver that support this week.

You can track the issue in this issue (coverage-reporter #137) on our repo for the GitHub Actions's underlying executable, coverage-reporter. That is the executable that needs the ARM64 support.

We have had more trouble than expected with this, so if not this week, we would hope to resolve by next week sometime.

SpayDolf commented 1 month ago

Why the fuck did I get this email?

SpayDolf commented 1 month ago

image

afinetooth commented 1 month ago

@SpayDolf, apparently because you are "a participant" (aka. following the issue):

Screenshot 2024-08-16 at 8 47 50 AM

I don't know how it happened---neither I nor @aaomidi can follow for you, and I don't see that either of us mentioned you in a comment.

But all you need to do to stop receiving notifications for this issue is remove yourself / unfollow, or unsubscribe:

Screenshot 2024-08-16 at 8 52 16 AM
SpayDolf commented 1 month ago

I think my device is being controlled remotely

afinetooth commented 1 month ago

Mine also has a mind of its own.

SpayDolf commented 1 month ago

image

SpayDolf commented 1 month ago

image

SpayDolf commented 1 month ago

Wtf is this lol I don't even own a watch

aaomidi commented 2 weeks ago

Did this get resolved? I see that the binary is now being built for ARM too?

afinetooth commented 2 weeks ago

Hi @aaomidi. Not quite yet. But we're close.

We've tried to cut a release with arm64 binaries twice now that we've pulled for issues discovered after the fact, so we are now adding more verification steps to our CI/CD process.

We genuinely hope to have it out today, but if not, then by Mon.

OJFord commented 1 week ago

@afinetooth Will we need to change anything to use it, or will it just start working, automatically using the right binary for an existing uses: coverallsapp/githubaction@v2?

afinetooth commented 1 week ago

Hi @OJFord.

We plan to make three (3) updates in this order and timeframe.

  1. This week - We'll cut a new release of coverage-reporter itself, which will include a new linux binary for aarch64 and provide instructions in its README for how to install and run that version.
  2. This week or next week - We'll cut new releases of our github-action and orb with new input options to specify which version of coverage-reporter to use.
  3. Next 4-6 weeks - We'll cut new releases of our github-action and orb that will automatically select the right version of coverage-reporter based on both runner OS and architecture (If possible. We have not validated this yet.)

So, until we can release (2) you won't have the option in the github-action; you would need to drop down to using the coverage-reporter directly until (2) is available.