Open ericdmoore opened 4 years ago
I'd love to hear your perspective on this implementation - perhaps there are features I am leaving on the table from your GitHub Action
🙏🙏🙏 Thank you, for posting this. This is the easiest way, i can think of for setting up a workflow (with REPO-TOKEN). After struggling with all different kinds of errors, i came across this issue.
Since Github actions are new, There are very few (nothing for my setup) blogs and videos for setting up this. It would be helpful for other peeps if you write a blog about this setup. So, it would be accessible to an easier rate.
Hey @Swarag-N thanks for the good vibes. I think I might write this up after all... I was hoping that there would have been more back and forth from the coveralls folks. But this is really one of my first real-suggestion-issue to an open source product, albeit still documentation oriented.
Perhaps I had overly optimistic expectations on response times.
Although this works, the setup doesn't even use the github-action that this repo is for. What you have done is an integration between coveralls-node
and Github Actions.
When you use the action provided in this repository, the github token is used to find the corresponding repository in Coveralls, and thus the repository token is not needed. Or at least that's my understanding.
But I will agree with you that a lot of work is needed in the documentation of this product, specially given that it has a paid version.
I found the JS/TS documentation a bit confusing as how to integrate the GithubActions/ CI. I really struggled on how to inject the secret:
COVERALLS_REPO_TOKEN
I could not get the
coveralls github action
to work... not sure if that was my laziness in not wanting to read more on the Github Actions or if there is bug...I eventually ended up usiung Github Secrets and the solution involves less magic (AKA GitHub Action Magic)
NPM Config Example
package.json
full reference is belowGitHub Action File Exmaple
nodejs.yml
full reference is belowNotice
All I needed to know when getting started with GitHub Actions was this line in the
nodejs.yml
COVERALLS_REPO_TOKEN : ${{ secrets.COVERALLS_REPO_TOKEN }}
...Just thought I would drop this in your issues so that any future person searching through here might be able to scratch their own itch on how to integrate their
npm run scripts
andGitHub Actions/ CI
Anyway nice product and keep up the great work. I am new user, and enjoying it so far.
Referenced Files
For the files in the wild, the two full blown config files are:
https://github.com/{{ org | user }}/{{ repo }}/settings/secrets
package.json
nodejs.yml