search

coverallsapp / github-action

Coveralls Github Action
https://github.com/marketplace/actions/coveralls-github-action
MIT License
468 stars 75 forks source link

Non-Unique value submitted as service_job_id #59

Open TimoRoth opened 4 years ago

TimoRoth commented 4 years ago

service_job_id is documented to be unique per job of a parallel build. Github Actions do not seem to provide anything like that, so leaving it blank is the only way to go about it.

So instead of assigning GITHUB_RUN_ID to COVERALLS_SERVICE_JOB_ID(in https://github.com/coverallsapp/github-action/blob/master/src/run.ts#L48), it should probably be assigned to COVERALLS_SERVICE_NUMBER. Which also matches up with the parallel-finish step submitting it as build_num.

fniephaus commented 4 years ago

FYI:

GITHUB_RUN_ID

A unique number for each run within a repository. This number does not change if you re-run the workflow run.

GITHUB_RUN_NUMBER

A unique number for each run of a particular workflow in a repository. This number begins at 1 for the workflow's first run, and increments with each new run. This number does not change if you re-run the workflow run.

See https://docs.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables#default-environment-variables