coverallsapp / orb

Coveralls CircleCI Orb
https://circleci.com/orbs/registry/orb/coveralls/coveralls
MIT License
2 stars 16 forks source link

Option to not fail build if Coveralls upload fails #14

Closed alex-deaconu closed 1 year ago

alex-deaconu commented 3 years ago

It's the second time in a short period of time that coveralls uploads fail due to their infrastructure issues. Builds should be allowed to pass despite this non critical failure.

Provide an option to not throw a critical error allowing builds to pass despite upload failures.

spiercey commented 3 years ago

As a quick fix for this in our projects we've removed the orb and brought the source into our projects and added || true to the calls to coveralls.

IE cat << parameters.path_to_lcov >> | coveralls || true

Note this isn't fully baked and has it's own downfalls but at least it isn't breaking our pipeline.

New issues:

In the long term we are planning on replacing the coveralls orb to solve those problems but in the short term the above could help you out quickly.

alex-deaconu commented 3 years ago

Thanks for the suggestion @spiercey. We just disabled the upload for now.

Previously we were doing something similar, but opted for the convenience of an orb. It's probably a good idea to phase it out as you've mentioning for the long term.