coverallsapp / orb

Coveralls CircleCI Orb
https://circleci.com/orbs/registry/orb/coveralls/coveralls
MIT License
2 stars 16 forks source link

Coveralls breaking again #45

Closed JustinAiken closed 1 month ago

JustinAiken commented 1 month ago

All CircleCI jobs went from passing, to failing:

sha256sum: release/coveralls-linux.tar.gz: No such file or directory
release/coveralls-linux.tar.gz: FAILED open or read
sha256sum: WARNING: 1 listed file could not be read

Exited with code exit status 1
afinetooth commented 1 month ago

@JustinAiken thanks for reporting. Same as this issue: https://github.com/coverallsapp/coverage-reporter/issues/165

Working on it now. Will update you here.

afinetooth commented 1 month ago

Suggestion in meantime:

set fail_on_error input option to false for now:

fail_on_error: false
JustinAiken commented 1 month ago

We do have fail_on_error set to false, it still failed 😞

EDIT: Relevant snippet of our config:

      - coveralls/upload:
          flag_name: rspec_unit_tests
          parallel: true
          fail_on_error: false
afinetooth commented 1 month ago

@JustinAiken hmm. Thanks. We'll need to look into that next.

afinetooth commented 1 month ago

Suggested workarounds for users of different extensions here.

afinetooth commented 1 month ago

@JustinAiken We believe we've patched this for now by updating the coveralls-checksums.txt file.

Can you please try again to see if it works for you now?

afinetooth commented 1 month ago

@JustinAiken we have reports from users of the github-action and coverage-reporter that our patch has fixed the issue for them.

I would love to make sure the same is the case for you with the orb before we move on to the root cause (and the fail_on_error thing).

badmintonkid commented 1 month ago

I'm not the reporter, but we had the same issue and can confirm our builds succeeded after your patch. Thanks for the quick resolution!

afinetooth commented 1 month ago

Great, thanks @badmintonkid!

afinetooth commented 1 month ago

Tested internally. Closing for now.

@JustinAiken please let us know if you're still having any issue with the orb using coverage-reporter v0.6.15.

Or reach out directly to support@coveralls.io since you're part of a paid subscription. Message for your subscription's users will route to me.)

afinetooth commented 4 weeks ago

@JustinAiken re:

We do have fail_on_error set to false, it still failed 😞

EDIT: Relevant snippet of our config:

      - coveralls/upload:
          flag_name: rspec_unit_tests
          parallel: true
          fail_on_error: false

We just released v2.2.2 of the coveralls orb, which extends the behavior of the fail_on_error option to setup tasks, like downloading, verifying and finding the coveralls binary.

Previously, fail_on_error only applied to failures of the coveralls commands, like coveralls report and coveralls done.

More here.