Closed phelipealves closed 4 years ago
Hi @phelipealves, thank you for the PR -- could you provide a use case description for this addition with links to a build on Circle using it, please?
Hi @nickmerwin, this build is made for an enterprise software from ESCALE.
This addition is used to confirm the parallel build. In our CI workflow, the coverage result will be sent to coveralls only when the code is in the master branch (staging environment). However, in pull requests or in another branch only coveralls jobs will be executed, without confirm.
job_id
. We used this variable because the coverage confirmation is performed in another circleci job and, in the last implementation, the CIRCLE_BUILD_NUM
number was not the same. Thus, coveralls confirmation would not be possible.token
is a environment variable and needs of dollar sign $
to be accessed by SO.This is a copy of our CircleCI configuration file: https://gist.github.com/phelipealves/ee66988027d2799a7e3694396de80fb1#file-config-yml-L165-L184
70427D0F-D52D-4C89-A414-0ABE964BA846
: https://i.ibb.co/RBHh6DV/Screenshot-from-2019-12-26-08-54-29.png.
build-and-test
coverage-done
Hi @nickmerwin, was added the case description in the last message :)
Hi @phelipealves, we've released a new version of node-coveralls that includes better handling of Circle's parallelism, and new version of the Orb that utilizes it.
We're using CIRCLE_WORKFLOW_ID
now as the Build Number that Coveralls will use to merge parallel job coverage.
Thank you again for the PR, and please confirm the new code solves your use-case when you have a chance.
Thanks!
This addition fix the confirmation of coveralls_parallel build. The environment variable _CIRCLE_WORKFLOWID is used to identify the coveralls job and confirm that the parallel task has completed.