coverallsapp / orb

Coveralls CircleCI Orb
https://circleci.com/orbs/registry/orb/coveralls/coveralls
MIT License
2 stars 16 forks source link

Add parameter service job id #5

Closed phelipealves closed 4 years ago

phelipealves commented 4 years ago

This addition fix the confirmation of coveralls_parallel build. The environment variable _CIRCLE_WORKFLOWID is used to identify the coveralls job and confirm that the parallel task has completed.

nickmerwin commented 4 years ago

Hi @phelipealves, thank you for the PR -- could you provide a use case description for this addition with links to a build on Circle using it, please?

phelipealves commented 4 years ago

Hi @nickmerwin, this build is made for an enterprise software from ESCALE.

This addition is used to confirm the parallel build. In our CI workflow, the coverage result will be sent to coveralls only when the code is in the master branch (staging environment). However, in pull requests or in another branch only coveralls jobs will be executed, without confirm.

This is a copy of our CircleCI configuration file: https://gist.github.com/phelipealves/ee66988027d2799a7e3694396de80fb1#file-config-yml-L165-L184

phelipealves commented 4 years ago

Hi @nickmerwin, was added the case description in the last message :)

nickmerwin commented 4 years ago

Hi @phelipealves, we've released a new version of node-coveralls that includes better handling of Circle's parallelism, and new version of the Orb that utilizes it.

We're using CIRCLE_WORKFLOW_ID now as the Build Number that Coveralls will use to merge parallel job coverage.

Thank you again for the PR, and please confirm the new code solves your use-case when you have a chance.

Thanks!