search

coverallsapp / orb

Coveralls CircleCI Orb
https://circleci.com/orbs/registry/orb/coveralls/coveralls
MIT License
2 stars 16 forks source link

Does this Orb require any changes to work with DockerHub auth? #8

Closed wheresrhys closed 1 year ago

wheresrhys commented 4 years ago

Describe Request:

When DockerHub starts rate limiting anonymous requests on Nov 1st, it looks like this Orb will be impacted, since there's no auth key in the docker config. It looks like a standard pattern is to expect DOCKERHUB_USERNAME/DOCKERHUB_PASSWORD environment variables (see example), will this (or something equivalent) be required for this Orb?

Examples:

https://discuss.circleci.com/t/updated-authenticate-with-docker-to-avoid-impact-of-nov-1st-rate-limits/37567/35

mrexox commented 1 year ago

Hey! I guess this is not required because it used to work fine. But if you face this issue you can configure the username/password pair. It's more about CI configuration rather than Orb.