search

coverlet-coverage / coverlet

Cross platform code coverage for .NET
MIT License
2.93k stars 385 forks source link

Making coverlet.msbuild msbuild properties more descriptive #1324

Open kovianyo opened 2 years ago

kovianyo commented 2 years ago

I have a csproj using coverlet.msbuild with the follwoing content:

  <PropertyGroup>
    <CoverletOutputFormat>cobertura</CoverletOutputFormat>
    <Exclude>[xunit.*]*</Exclude>
    <CollectCoverage>true</CollectCoverage>
  </PropertyGroup>

When I first looked at it, I was wondering what the property Exclude could be.

The property name Exclude does not really hint to the fact that it is used by coverlet.msbuild. An extended name, for example CoverletExcludeFilters would better show what the property is used for, and could avoid possible conflicts.

What do you think?

MarcoRossignoli commented 2 years ago

I think it's true, historically the naming for the msbuild runner wasn't never been good. We can think to change it if we'll have enough request for that, I'll keep this issue open for some time to see if there's some interest.

This is the list of the used vars https://github.com/coverlet-coverage/coverlet/blob/master/src/coverlet.msbuild.tasks/coverlet.msbuild.props

github-actions[bot] commented 10 months ago

This issue is stale because it has been open for 3 months with no activity.

github-actions[bot] commented 2 months ago

This issue is stale because it has been open for 3 months with no activity.