coverlet.msbuild.tasks unit tests

coverlet-coverage / coverlet

Cross platform code coverage for .NET

MIT License

2.98k stars 386 forks source link

coverlet.msbuild.tasks unit tests #1534

Closed Bertk closed 11 months ago

Bertk commented 1 year ago

add CoverageResultTaskTests.cs for coverlet.msbuild.tasks unit test
allows local debugging of msbuild tasks
removes system.console output in ReportWriter (potential conflicts - msbuild task logging)

Bertk commented 1 year ago

The CI build fails with /p:CollectCoverage=true and my local test execution fails with a different message

Everything is fine without /p:CollectCoverage=true.

... and suddenly the CI does not show test errors anymore with enabled code coverage.

Bertk commented 1 year ago

I see formatting and updates, maybe it's better avoid to format here and add only tests to make the review easier, we could lose some small detail

This is will be fixed with the other PR #1529 . The source code files are not in sync with the current definitions of .editorconfig. By the way, the format on save VS feature cannot be used until the source files are harmonized.

https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/csharp-formatting-options

Bertk commented 11 months ago

@daveMueller By the way, could you please check whether mandatory checks are defined? Otherwise a PR with a broken build pipeline could be merged.

This configuration is available in Settings->branches->branch protection

daveMueller commented 11 months ago

@daveMueller By the way, could you please check whether mandatory checks are defined? Otherwise a PR with a broken build pipeline could be merged.

This configuration is available in Settings->branches->branch protection

Sorry I also don't have permission to look into that. Maybe @MarcoRossignoli can? But I'm pretty sure that PRs with a failed build job can't be merged.