coverlet-coverage / coverlet

Cross platform code coverage for .NET
MIT License
2.93k stars 385 forks source link

Fix TypeInitializer issue #1636

Closed daveMueller closed 3 months ago

daveMueller commented 4 months ago

closes #1629

OK I guess I need a review here. Changing the tfm of core to only netstandard2.0 fixes the problem. But from my perspective the CoverletToolsPath should also be resolved properly. The change of the condition for CoverletToolsPath I did in this PR still doesn't seem to work properly. No matter what I do it always point to netstandard2.0

CoverletToolsPath = C:\Users\...\.nuget\packages\coverlet.msbuild\6.0.2-preview.7.ga760715d51\build\..\tasks\netstandard2.0\

But what I think, for e.g. net6 it should point to

CoverletToolsPath = C:\Users\...\.nuget\packages\coverlet.msbuild\6.0.2-preview.7.ga760715d51\build\..\tasks\net6.0\

@MarcoRossignoli @Bertk Am I missing something? Can you help out here?

MarcoRossignoli commented 3 months ago

conflict but LGTM