Add option to give warning instead of failing the build if coverage is below threshold

coverlet-coverage / coverlet

Cross platform code coverage for .NET

MIT License

2.99k stars 386 forks source link

Add option to give warning instead of failing the build if coverage is below threshold #1670

Open roostaamir opened 4 months ago

roostaamir commented 4 months ago

This will enable the option to choose if the build should fail when the coverage is below the threshold or just give a warning about it
Based on the initial idea that started here: https://github.com/coverlet-coverage/coverlet/issues/701

roostaamir commented 4 months ago

To the reviewer:

I need a bit of help to decide where to write tests for the new functionality. Could you please give me a suggestion about where would be the best test project to write test for this newly introduced parameter?

Thanks in advance

roostaamir commented 4 months ago

@dotnet-policy-service agree

roostaamir commented 3 months ago

Hi again

Are there any updates about comments or reviews on my PR?

Bertk commented 2 months ago

Thank you for the contribution.

Maybe an additional test in DotnetTool.cs should verify the new command line option.

By the way, I would use bool ThresholdWarn instead of enum ThresholdAction.

Unfortunately, I do not have the PR approve permission. @MarcoRossignoli, @daveMueller Could you please review this PR.

MarcoRossignoli commented 2 months ago

Maybe an additional test in DotnetTool.cs should verify the new command line option.

I agree could be good add some tests for it

roostaamir commented 2 months ago

Thank you very much @Bertk and @MarcoRossignoli

I will make the requested changes and update the PR :)