MarcoRossignoli
commented
5 years ago Hi Oren, I did some check and it's related to instrumentation, that test seem a performance test comparison https://github.com/onovotny/bc-csharp/blob/netstandard/crypto/test/src/math/ec/test/ECPointPerformanceTest.cs#L21 that lead to a lot of call to instrumentation code
I did a debug with msbuild but nothing different core is the same
dotnet test /p:CollectCoverage=true /p:Exclude=\"[xunit.*]*,[*Tests]*,[nunit.*]*,[NUnit3.*]*\" /p:ExcludeByAttribute=\"Obsolete,GeneratedCodeAttribute,CompilerGeneratedAttribute\" /p:SingleHit=true /p:CoverletToolsPath=C:\git\coverlet\src\coverlet.msbuild.tasks\bin\Debug\netstandard2.0\With SingleHit=true should be better...but maybe you should exclude that test from "coverage check".
In my test I get result after some minutes
C:\git\coverletissue\bc-csharp\crypto\test (HEAD detached at 4a401ed -> origin)
λ dotnet test /p:CollectCoverage=true /p:Exclude=\"[xunit.*]*,[*Tests]*,[nunit.*]*,[NUnit3.*]*\" /p:ExcludeByAttribute=\"Obsolete,GeneratedCodeAttribute,CompilerGeneratedAttribute\" /p:SingleHit=true /p:CoverletToolsPath=C:\git\coverlet\s
rc\coverlet.msbuild.tasks\bin\Debug\netstandard2.0\
...
Avvio dell'esecuzione dei test in corso. Attendere...
! TestFunction
! TestSumOfMultipliesComplete [1ms]
! TestSumOfTwoMultipliesComplete
! TestMultiply
L'esecuzione dei test è riuscita.
Total tests: 995
Passed: 991
Tempo di esecuzione dei test: 24,4505 Minuti
Calculating coverage result...
Generating report 'C:\git\coverletissue\bc-csharp\crypto\test\coverage.json'
+---------------------+--------+--------+--------+
| Module | Line | Branch | Method |
+---------------------+--------+--------+--------+
| BouncyCastle.Crypto | 75,16% | 62,9% | 72,22% |
+---------------------+--------+--------+--------+
+---------+--------+--------+--------+
| | Line | Branch | Method |
+---------+--------+--------+--------+
| Total | 75,16% | 62,9% | 72,22% |
+---------+--------+--------+--------+
| Average | 75,16% | 62,9% | 72,22% |
+---------+--------+--------+--------+
@jkotas do you think that aggressive inlining could help here(I think that tiering cannot help to remove the call)
clairernovotny
jkotas
Bertk
Hi,
When adding coverage for .NET Framework, it's causing hangs. It works fine on .NET Core: https://dev.azure.com/onovotny/GitBuilds/_build/results?buildId=2203&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9
This commit has the changes: https://github.com/onovotny/bc-csharp/commit/5ddb17530b4175ce31092ac671d2ed496c2ecd06
Here's the command that fails, when on .NET Framework: https://github.com/onovotny/bc-csharp/commit/5ddb17530b4175ce31092ac671d2ed496c2ecd06
Seems like it's happening with .NET Core too: https://dev.azure.com/onovotny/GitBuilds/_build/results?buildId=2204&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=bfbec40a-1b5e-5690-b870-859627cad0c0&l=20
Should be able to repro with
dotnet test -f netcoreapp2.1 ...Repro steps:
Clone:
https://github.com/onovotny/bc-csharpCheckout commit:4a401ed22df13ef61b2bb7a306ee8a083167f1c6Go tocrypto\testRundotnet test -f netcoreapp2.1and see that it passes. About 1.5 min on my machine Rundotnet test -f netcoreapp2.1 -s ..\..\CodeCoverage.runsettingsTests are taking much longer to run (never complete) and fail in some cases.
I think it's struggling on this test: https://github.com/onovotny/bc-csharp/blob/netstandard/crypto/test/src/math/ec/test/ECPointPerformanceTest.cs#L176
Perhaps with some of the random number generators in use there?