search

covermymeds / puppet-sentry

Install and manage Sentry with Puppet!
MIT License
7 stars 7 forks source link

Support installation from URLs #20

Closed skpy closed 8 years ago

skpy commented 8 years ago

The primary intent of this PR is to allow installation of Sentry from a URL. This allows Sentry to be installed via pip directly from GitHub, rather than PyPI.

It also adds support for installing extensions from URLs, by taking a hash of extensions to install in the format {extension_name => extension_url}.

Closes #19

The Sentry team has been moving a lot of configuration from sentry.conf.py to config.yml, so this PR addresses some of those. See https://docs.getsentry.com/on-premise/server/warnings/ This includes updating the SENTRY_CONF and --config options to point to the Sentry path, rather than a specific config file.

And I've updated most of the Python helper scripts and WSGI file to use virtualenv's activate_this.py script.

I don't think this PR is quite complete: I want to test both fresh installs and upgrades a few more times ot make sure everything is working. But I want to get this out for review earlier, rather than later.

skpy commented 8 years ago

The execfiles are there now. They weren't part of the commits on which you commented @nchowning. Double-check, though, please.

skpy commented 8 years ago

The python::pip documentation states that the default is "none". The code sets it to false. If we specify undef in our invocation, it should fall through to the module's default value, I think. We could default to false, though, to be explicit and conformant with the module's default.

nchowning commented 8 years ago

Cool. I think that it would work out in the wash as undef but setting it to false is probably the safer approach. 👍

skpy commented 8 years ago

When upgrading, the Celery worker is not fully restarted. This has the Sentry web interface complaining:

Celery workers are referencing a different version of Sentry (8.4.1 vs 8.1.2)

skpy commented 8 years ago

Rather than have this PR increase any further in scope, I think it's ready to merge. I'll address the other recently opened issues in a new PR, and then we can cut a new release.

Your thoughts, @nchowning @dansajner ?

nchowning commented 8 years ago

@skpy Sounds like a good plan to me!