covermymeds / puppet-sentry

Install and manage Sentry with Puppet!
MIT License
7 stars 7 forks source link

Resource ordering problem #22

Closed skpy closed 8 years ago

skpy commented 8 years ago

The resource for sentry.conf is defined in init.pp. It is not explicitly declared as a dependency for any of the setup tasks performed in install.pp, which may permit the catalog to try to execute those tasks before the file is created. This is wrong.

Everything that install.pp needs should be handled in advance of invoking that class. I propose a setup.pp class that ensures that the Sentry user and group are managed, as well as the target installation directory. Then the sentry.conf file resource can depend on setup.pp and finally install.pp can depend on the configuration file.