Closed skpy closed 8 years ago
skpy
commented
8 years ago @dansajner @nchowning I've pushed another change, after successfully testing the include-like containment solution. I was thrown off last week by a typo in one of the class parameters! Once this was fixed, testing worked as I expected.
Please review!
skpy
commented
8 years ago I think all outstanding issues have been resolved, and this is ready to merge.
I have elected to manage both the sentry-worker and sentry-beat services, since the documentation explicitly describes background workers and the beat cron process.
I have performed an upgrade from an 8.1.2 install to 8.4.1, with a ~7GB database. The database migrations ran automatically just fine.
Once we merge, we can update our own installation from the git master branch. When that proves successful, we can cut a new Puppet Forge release. In the event that additional tweaks are necessary, we can make them in master before making the Forge release, so as to minimize iteration on that process.
dansajner
commented
8 years ago 👍 to merge. 🏆 for @skpy
This is a pretty big reworking to account for on-going Sentry development.
The biggest changes are:
sentry::configandsentry::setupclassesDue to changes in the upstream Sentry code and how it handles configuration, this module will not be able to install older versions of Sentry. The default version to install is
latest, which at this time is 8.4.1. Arbitrary versions can be installed, but I have only tested it with [8.4.0].Upgrades from older version of Sentry managed by older versions of this module should work just fine, provided both happen in tandem. That is to say: using puppet-sentry 2.0.1 with Sentry 8.0.0, you can upgrade to puppet-sentry 3.0.0 and Sentry 8.4.1 simultaneously. Other combinations have not been tested at this time.