search

covermymeds / puppet-sentry

Install and manage Sentry with Puppet!
MIT License
7 stars 7 forks source link

Allow using pip for extension installation #33

Open benh57 opened 7 years ago

benh57 commented 7 years ago

Fixes:

Warning: sentry has an invalid and unparsable metadata.json file. The parse error: 399: unexpected token at '{ "name": "yo61/logrotate", "version_requirement:" ">= 1.3.0" } ]

Also allowing to pass false as an extension's url. This lets python::pip just use pip default.

adamcstephens commented 7 years ago

The default for url is a boolean false in params. What is this extra logic accomplishing besides parsing a string with the word false in it?

adamcstephens commented 7 years ago

We're also already requiring Puppet 4, so we should really type cast the parameters in this and other classes to avoid needing the logic.

benh57 commented 7 years ago

Boolean false fails with an error due to the String typecast. (the |String $extension, String $url) Feel free to fix another way... didnt mean to add that one to the same pull request, accidentally submitted to master :)

benh57 commented 7 years ago

To reproduce the extension problem, try:

sentry::extensions: sentry-jira: false

My intention is to install this with pip without passing a url.

benh57 commented 7 years ago

Looks like this might actually work and do just what i want:

$extensions.each |String $extension, Variant[String, Boolean] $url| {

I'll test it out a bit more and update the PR.

adamcstephens commented 7 years ago

Any update on this @benh57 ?