search

covid-alert-ny / covid-green-app

Covid Alert NY - React-Native App
Apache License 2.0
6 stars 1 forks source link

The 'Update Settings' button under 'My Covid Alerts' page is not opening up my phone settings. #126

Open mboskin opened 4 years ago

mboskin commented 4 years ago

Android | Galaxy S6+ | 8/27/2020 5:40PM | Raghunath Gajjala

The 'Update Settings' button under 'My Covid Alerts' page (under App Settings menu) is not opening up my phone settings.

floridemai commented 4 years ago

@mboskin I think this was happening on older versions. Do you know the version this was tested against?

mboskin commented 4 years ago

Linh, please confirm the following.

Android | Galaxy S6+ | 8/27/2020 5:40PM | Raghunath Gajjala

Yesterday at 5:40 PM they were testing the current build.

www.nystec.comhttp://www.nystec.com/

From: Paul Negrutiu notifications@github.com Sent: Friday, August 28, 2020 11:52 AM To: project-vagabond/covid-green-app covid-green-app@noreply.github.com Cc: Mention mention@noreply.github.com Subject: Re: [project-vagabond/covid-green-app] The 'Update Settings' button under 'My Covid Alerts' page is not opening up my phone settings. (#126)

[External Email]

@mboskinhttps://github.com/mboskin I think this was happening on older versions. Do you know the version this was tested against?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/project-vagabond/covid-green-app/issues/126#issuecomment-682756343, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQYJBUEW5VFQDBD2V2YPNRDSC7HC7ANCNFSM4QNRUG4A.

floridemai commented 4 years ago

@mboskin A couple of updates on the ticket: ✔️ I have update the page to be in sync with the other closeness sensing screen. The existing code was old and even if in essence could have worked, it wasn't up to date. ✔️ Updated text to match designs ❗ The reported bug does indeed exist but a couple of notes should be made. Only happens on Android. Only happens when Closeness is active, you tap the button and then in the settings screen you don't do anything and instead of using the back arrow or phone back you choose to "Open app" from that screen which re-opens the app. Furthermore if you close the app and then re-open it, the button is again working properly.

My current changes should be in in the next release, prior to Monday's build.

@mboskin Fixing this could take quite a bit of time as it involves looking into android native code when the app starts. Not sure if we should put it on the top of our list. cc @dharding @arybka777 @kevin-sheldon. For the time being, this has been looked into and addressed and I'll re-assign it.

Note to developers: We open ENS settings with

        await IntentLauncher.startActivityAsync(
          'com.google.android.gms.settings.EXPOSURE_NOTIFICATION_SETTINGS'
        );

and subsequent calls error with

[Error: IntentLauncher activity is already started. You need to wait for its result before starting another activity.]

for obvious reasons.

colmharte commented 4 years ago

Changing this low priority, its an edge case and there are simple work arounds